-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#172 Charging Screen Improvements #179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set button for graphs, cell voltage comp has decimal padding for whole numbers
This comment was marked as resolved.
This comment was marked as resolved.
…ents for graph-component changes
RChandler234
requested changes
Sep 19, 2024
angular-client/src/pages/charging-page/charging-page-mobile/charging-page-mobile.component.ts
Show resolved
Hide resolved
...rging-page/components/high-low-cell/high-low-cell-display/high-low-cell-display.component.ts
Outdated
Show resolved
Hide resolved
...charging-page/components/pack-voltage/pack-voltage-display/pack-voltage-display.component.ts
Outdated
Show resolved
Hide resolved
angular-client/src/pages/charging-page/components/active-status/active-status.component.ts
Outdated
Show resolved
Hide resolved
RChandler234
requested changes
Sep 20, 2024
angular-client/src/pages/charging-page/components/active-status/active-status.component.ts
Outdated
Show resolved
Hide resolved
RChandler234
requested changes
Sep 20, 2024
...charging-page/components/pack-voltage/pack-voltage-display/pack-voltage-display.component.ts
Outdated
Show resolved
Hide resolved
RChandler234
requested changes
Sep 20, 2024
...rc/pages/charging-page/components/cell-temp/cell-temp-display/cell-temp-display.component.ts
Outdated
Show resolved
Hide resolved
...charging-page/components/pack-voltage/pack-voltage-display/pack-voltage-display.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charging Screen Improvements
Changes
Implemented all of the todo below, to summarize:
added time based status lights (which save total times using sessionStorage, to avoid reset on page refresh)
and re-arranged existing components, adding more space for graphs (as well as merging changes to the graph component form #180)
Test Cases
Screenshots
50% zoom
100% zoom
110% (small cut off but not too bad)
1200px and below (just switches to mobile view) The fault component is a lil wonky on there I can fix up tmrw.
video: https://github.com/user-attachments/assets/f48cdaa0-c89e-419e-9987-783ec8518efb
To Do
Any remaining things that need to get done
Checklist
It can be helpful to check the
Checks
andFiles changed
tabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.json
changes (unless dependencies have changed)Closes #172