Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#172 Charging Screen Improvements #179

Merged
merged 36 commits into from
Sep 20, 2024

Conversation

bracyw
Copy link
Contributor

@bracyw bracyw commented Aug 2, 2024

Charging Screen Improvements

Changes

Implemented all of the todo below, to summarize:
added time based status lights (which save total times using sessionStorage, to avoid reset on page refresh)

and re-arranged existing components, adding more space for graphs (as well as merging changes to the graph component form #180)

Test Cases

  • Manual

Screenshots

50% zoom
Screenshot 2024-09-15 at 7 58 32 PM
100% zoom
Screenshot 2024-09-15 at 7 58 46 PM
110% (small cut off but not too bad)
Screenshot 2024-09-15 at 8 03 28 PM
1200px and below (just switches to mobile view) The fault component is a lil wonky on there I can fix up tmrw.
video: https://github.com/user-attachments/assets/f48cdaa0-c89e-419e-9987-783ec8518efb
Screenshot 2024-09-15 at 8 08 53 PM
Screenshot 2024-09-15 at 8 09 08 PM
Screenshot 2024-09-15 at 8 09 21 PM
Screenshot 2024-09-15 at 8 09 35 PM

To Do

Any remaining things that need to get done

  • Re-arrange/Combine Status Components:
    • Visual layout resembling the inner state representation:
      • Active (current != 0)
        • Charging (control = 0)
          • Balancing or not
        • Paused Charging (control = 1)
          • Balancing or not
      • Inactive, faulted (state = 3) or not yet enabled (Charger/Box not sending messages)
  • Update Pack Voltage and Cell Temp Graphs:
    • Ensure graphs show values across the whole charging session.
  • Enhance Fault Component:
    • Make component bigger.
    • Include Sheperd faults.
    • Specify fault sources (BMS or Charging Cart).
  • New Additions:
    • Label: Started charging at this timestamp.
    • Duration in Charging Mode and Balancing Mode for the whole session.
  • Mobile page?

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No package-lock.json changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #172

…set button for graphs, cell voltage comp has decimal padding for whole numbers
@bracyw bracyw self-assigned this Aug 2, 2024
@jr1221

This comment was marked as resolved.

@bracyw bracyw marked this pull request as draft August 18, 2024 02:16
@bracyw bracyw marked this pull request as ready for review August 20, 2024 21:12
@bracyw bracyw marked this pull request as draft August 20, 2024 21:31
@bracyw bracyw marked this pull request as ready for review September 5, 2024 19:57
RChandler234

This comment was marked as resolved.

@RChandler234 RChandler234 merged commit ff93b14 into develop Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charging Screen Improvements
3 participants